Skip to content

Remove aveta dependency from Google Search Console to avoid crasher#640

Merged
niekert merged 1 commit into
mainfrom
codex/drop-aveta-google-search-console
May 5, 2026
Merged

Remove aveta dependency from Google Search Console to avoid crasher#640
niekert merged 1 commit into
mainfrom
codex/drop-aveta-google-search-console

Conversation

@niekert
Copy link
Copy Markdown
Member

@niekert niekert commented May 5, 2026

Description

This was causing some issues with Vite 8 production bundling, and should never have been a dependency in the first place

Changelog

  • Fixes a crasher when visitor numbers are formatted

Testing

  • No more crashers
    • On a production build of the plugin
    • The plugin no longer crashes in the Performance component

Copilot AI review requested due to automatic review settings May 5, 2026 10:31
@github-actions github-actions Bot added the Auto submit to Marketplace on merge Submits the plugin to the marketplace after merging label May 5, 2026
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR removes the aveta dependency from the Google Search Console plugin (to address Vite 8 production bundling issues) and replaces it with an in-repo stat formatting helper.

Changes:

  • Removed aveta from plugins/google-search-console dependencies (and cleaned up yarn.lock).
  • Updated the Performance screen to use a new local formatStat helper for click/impression totals.
  • Added unit tests for formatStat and added a check-vitest script for the plugin.

Reviewed changes

Copilot reviewed 4 out of 12 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
yarn.lock Removes aveta and its transitive deps from the lockfile.
plugins/google-search-console/package.json Drops aveta dependency; adds check-vitest script.
plugins/google-search-console/src/screens/Performance.tsx Replaces aveta(totalX) with formatStat(totalX) for displayed totals.
plugins/google-search-console/src/formatStat.ts Adds local stat-abbreviation formatter (K/M/B/…).
plugins/google-search-console/src/formatStat.test.ts Adds Vitest coverage for formatting and edge cases.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread plugins/google-search-console/src/formatStat.ts Outdated
Copy link
Copy Markdown
Collaborator

@huntercaron huntercaron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems chill!

@niekert niekert force-pushed the codex/drop-aveta-google-search-console branch from 5cb6724 to a67df69 Compare May 5, 2026 10:46
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
@niekert niekert force-pushed the codex/drop-aveta-google-search-console branch from a67df69 to 67a4ad7 Compare May 5, 2026 10:49
@niekert niekert changed the title Remove aveta dependency from Google Search Console Remove aveta dependency from Google Search Console to avoid crasher May 5, 2026
@niekert niekert added this pull request to the merge queue May 5, 2026
Merged via the queue into main with commit 5b6621e May 5, 2026
11 checks passed
@niekert niekert deleted the codex/drop-aveta-google-search-console branch May 5, 2026 10:56
@niekert niekert deployed to production May 5, 2026 10:56 — with GitHub Actions Active
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Auto submit to Marketplace on merge Submits the plugin to the marketplace after merging

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants